-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capr Issue #99: Potential improvements to Capr #102
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to countOccurences
copy files from PHEMS repo && updates to code
gitignore .Rprofile
thanks @guuswilmink can you please recreate this PR targeting the develop branch instead of the main branch. As part of the HADES procedure, any feature changes need to go to the develop branch first. Then we do a release on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to Issue #99.
Suggested functions:
isStandard.R: Given a path to CSV files with at least fields "sourceCode" and "conceptId", along with a database connection with a CDM and vocabulary schema, return a tibble of non-standard concepts. Allows for export of results for all concepts included (including standard). This function can help in quickly identifying non-standard concepts from tables of concept ids.
isStandardDB.R: Checks whether concepts that exist in a database are standard/non-standard and returns the non-standard concepts. The full table of standard and non-standard concepts can be saved as well. This is probably the most useful out of the 3 isStandard functions.
isStandardCS.R: Similar return as isStandard.R and isStandardDB, but performs the check given a Capr ConceptSet class object rather than CSV files. Does not capture source value (as these are not relevant for concept sets).
countOccurrences.R: Given a vector of concept IDs and a connection to a CDM instance, count the number of occurrences of: 1) persons with concept 'x'; 2) records with concept 'x'; 3) persons with concept 'x' or descendants of 'x'; 4) records with concept 'x' or descendants of 'x'
To demonstrate and further clarify this function I have attached a PDF with example usage. Is this already possible within Capr?
@mdlavallee92 I have incorporated your feedback provided in issue #99; please let me know if this is to your expectations.