Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Banner not shown due to Ad Blocker Browser Extensions #99

Closed
damsfx opened this issue Oct 4, 2023 · 3 comments
Closed

Cookie Banner not shown due to Ad Blocker Browser Extensions #99

damsfx opened this issue Oct 4, 2023 · 3 comments

Comments

@damsfx
Copy link
Contributor

damsfx commented Oct 4, 2023

I've just realised that the browser extension AdBlocker Ultimate is blocking access to the cookie consent banner.

The extension adds a css rule to the browser making the banner inoperable:

.gdpr-banner:not(html):not(body) {
    display: none!important;
}

After decompiling the Firefox extension, I see that several rules are generated automatically from the filter_3.txt file.
This rules file is generated from the rules defined in
https://github.com/lassekongo83/Frellwits-filter-lists/blob/b243f5427771d00e3e0390ef21ff2f283011e18a/Frellwits-Swedish-Filter.txt#L136
and
https://github.com/easylist/easylist/blob/014b05742117b7706d563978eeecd5ef81c20ff5/easylist_cookie/easylist_cookie_general_block.txt#L572-L573

These filter lists are shared by many ad blockers, so the problem may also occur with other browser extensions of the same type.

So far the only workaround for me, is to redefine the banner partial in my site theme and give it a different css class from the original.
So I also need to redefine the css rules applied to this new component in my style.

@tobias-kuendig
Copy link
Member

This does not seem like a problem with the plugin to me. If someone installs an adblocker and uses a cookie banner block list to hide the banner, everything works exactly as expected.

@damsfx
Copy link
Contributor Author

damsfx commented Oct 4, 2023

This does not seem like a problem with the plugin to me. If someone installs an adblocker and uses a cookie banner block list to hide the banner, everything works exactly as expected.

The aim was not to report this as a bug, but rather as a warning.
Other users may also experience the same problem.

@tobias-kuendig
Copy link
Member

Good thinking, thank you!

@tobias-kuendig tobias-kuendig reopened this Oct 5, 2023
@tobias-kuendig tobias-kuendig pinned this issue Oct 5, 2023
@tobias-kuendig tobias-kuendig changed the title Cookie banner not show due to browser Ad blocker Cookie Banner not shown due to Ad Blocker Browser Extensions Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants