Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test from issue 1008 #1211

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add test from issue 1008 #1211

merged 2 commits into from
Aug 20, 2024

Conversation

Halbaroth
Copy link
Collaborator

This commit adds a test suggested by Basile in issue #1008.

@bclement-ocp
Copy link
Collaborator

I think we should also add the failing:

(set-logic ALL)
(declare-datatype t ((B (i Int))))

(declare-const e t)

(assert ((_ is B) e))
(assert (forall ((n Int)) (distinct e (B n))))
(check-sat)

And we would expect it to get fixed in #1211.

This commit adds tests suggested by Basile in issue OCamlPro#1008.
Copy link
Collaborator

@bclement-ocp bclement-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected files seem to be empty but OK to merge with the correct expected files.

(declare-const e t)

(assert ((_ is B) e))
(assert (forall ((n Int)) (distinct e (B n))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note somewhere that "this currently returns unknown but we want it to return unsat once #1008 is fixed", to avoid thinking there is a soundness issue with the fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the note in #1008.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale for adding a note in the test itself is that if a test fails, the test file is the first place we are going to look.

@Halbaroth
Copy link
Collaborator Author

Rofl, I forgot to call make promote.

@Halbaroth Halbaroth enabled auto-merge (squash) August 20, 2024 09:46
@Halbaroth Halbaroth merged commit dbfb6ad into OCamlPro:next Aug 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants