-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test from issue 1008 #1211
Add test from issue 1008 #1211
Conversation
I think we should also add the failing:
And we would expect it to get fixed in #1211. |
This commit adds tests suggested by Basile in issue OCamlPro#1008.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected files seem to be empty but OK to merge with the correct expected files.
(declare-const e t) | ||
|
||
(assert ((_ is B) e)) | ||
(assert (forall ((n Int)) (distinct e (B n)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a note somewhere that "this currently returns unknown
but we want it to return unsat
once #1008 is fixed", to avoid thinking there is a soundness issue with the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the note in #1008.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale for adding a note in the test itself is that if a test fails, the test file is the first place we are going to look.
Rofl, I forgot to call |
This commit adds a test suggested by Basile in issue #1008.