Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up: check-all-sat feature #847

Closed
9 tasks
Halbaroth opened this issue Sep 29, 2023 · 1 comment
Closed
9 tasks

clean-up: check-all-sat feature #847

Halbaroth opened this issue Sep 29, 2023 · 1 comment

Comments

@Halbaroth
Copy link
Collaborator

Halbaroth commented Sep 29, 2023

This issue is a reminder to all things we have to do to get a clean check-all-sat feature.

  • supporting check-all-sat with the solver FunSAT. As I explained in feat: check-all-sat support #846, the current output of the option --all-sat is strange when we use the solver FunSAT. Indeed, FunSAT isn't a CDCL solver. It didn't produce a partial boolean model of the clauses. In particular, it forgot every declared symbols in an abandoned branch.
  • supporting check-all-sat in Dolmen.
  • check-all-sat should work if we use (set-option :produce-models true) in the SMT-LIB language.
  • Test check-all-sat with --dump-models.
  • Improve the printer while using this command.
  • Choose between --all-sat or --all-models. Both are weird. I suggest --produce-all-bool-models or adding a argument to the command --produce-models. We could do the same with --dump-models for the native input language.
  • Add documentation about the feature and modify the change log.
  • Producing new declaration in the module Frontend.ml isn't a neat design. We should add a new command to the SAT interface sig_sat.mli for check-all-sat.
  • Add tests and cram tests.
@Halbaroth Halbaroth changed the title Clean up the check-all-sat clean-up: check-all-sat feature Sep 29, 2023
@Halbaroth
Copy link
Collaborator Author

We decided to not support this feature in a near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant