Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] website_analytics_umami #920

Closed
wants to merge 12 commits into from
Closed

[16.0][ADD] website_analytics_umami #920

wants to merge 12 commits into from

Conversation

yibudak
Copy link

@yibudak yibudak commented Oct 28, 2022

Umami is a simple, fast, privacy-focused alternative to Google Analytics. (https://github.com/umami-software/umami). It's a new project, but it is growing very fast. Assuming that Odoo 16 is the latest version, I wanted to add the Umami module to the website repo with this PR.

image

tarteo
tarteo approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@yibudak
Copy link
Author

yibudak commented Apr 26, 2023

Umami grows continuously, is there any chance to merge? @pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 26, 2023
@pedrobaeza
Copy link
Member

Please review other PRs and ask in exchange that they review yours. You need 2 positive reviews, and one from a PSC for this being merged.

https://odoo-community.org/resources/review
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

@yibudak
Copy link
Author

yibudak commented Apr 26, 2023

Please review other PRs and ask in exchange that they review yours. You need 2 positive reviews, and one from a PSC for this being merged.

https://odoo-community.org/resources/review https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

Thanks for your quick answer. I will work on it.

@pedrobaeza
Copy link
Member

For this one, please squash all the commits into one, as they don't bring added value to be separated.

@yibudak
[16.0][ADD] website_analytics_umami
4f4acb6 
[16.0][FIX] pre-commit / pre-commit (pull_request) fixes

[16.0][FIX] hook id: black fixes

[16.0][FIX] capitalized module name

[16.0][FIX] symlink added
@yibudak
Copy link
Author

yibudak commented Apr 26, 2023

For this one, please squash all the commits into one, as they don't bring added value to be separated.

Done. Thank you.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 10, 2023
@github-actions github-actions bot closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yibudak @pedrobaeza @tarteo