-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] website_form_require_legal: Migration to version 16.0 #1003
[16.0][MIG] website_form_require_legal: Migration to version 16.0 #1003
Conversation
/ocabot migration website_form_require_legal |
5c6f34a
to
f642fbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f642fbe
to
68fbc4b
Compare
I tried again locally, it should no longer happen |
is a error in the website_crm_privacy_policy module, it is corrected at #1014 |
…at website form level
Currently translated at 100.0% (4 of 4 strings) Translation: website-15.0/website-15.0-website_form_require_legal Translate-URL: https://translation.odoo-community.org/projects/website-15-0/website-15-0-website_form_require_legal/de/
68fbc4b
to
d2202f3
Compare
@CarlosRoca13 The error you were experiencing in runbot in the contact form is already fixed in the other module, however the functionality test has to be done by inserting a new form block as the other module already has the contact form customised and only allows editing the link. In local tests where the two modules do not coexist, the functionality is also applied to the contact form, so to check that it really works you would have to do it without the other module marked as "deprecated" installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review: LGTM
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at facc049. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT44376
@chienandalu @CarlosRoca13 please review