Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] bank_statement_check_number #402

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[14.0][ADD] bank_statement_check_number #402

merged 1 commit into from
Aug 25, 2023

Conversation

ps-tubtim
Copy link
Member

@ps-tubtim ps-tubtim commented Aug 11, 2021 •
edited
Loading

This module adds a check number column in the bank statements lines.

Waiting for

@OCA-git-bot
Copy link
Contributor

Hi @ps-tubtim! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch 2 times, most recently from 7799ffd to dfc37ac Compare August 11, 2021 07:59
@ps-tubtim ps-tubtim mentioned this pull request Sep 13, 2021
Merged
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch 3 times, most recently from b0e290c to d1519bf Compare September 19, 2021 00:20
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch from d1519bf to 444b55a Compare January 6, 2022 04:20
@ps-tubtim ps-tubtim mentioned this pull request Jan 6, 2022
Closed
2 tasks
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch from 444b55a to a6b9381 Compare March 15, 2022 16:22
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch from a6b9381 to 9654c9a Compare May 29, 2022 06:37
@ps-tubtim ps-tubtim mentioned this pull request Jul 4, 2022
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 2, 2022
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch from 9654c9a to 5751b30 Compare October 5, 2022 08:37
@ps-tubtim ps-tubtim force-pushed the 14.0-add-bank_statement_check_number branch from 5751b30 to c5c66b3 Compare October 5, 2022 08:40
Saran440
Saran440 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍 run on production

@github-actions github-actions bot closed this Nov 20, 2022
@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Aug 25, 2023
AaronHForgeFlow
AaronHForgeFlow approved these changes Aug 25, 2023
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests on production

mariadforgeflow
mariadforgeflow approved these changes Aug 25, 2023
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AaronHForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-402-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b3f0620 into OCA:14.0 Aug 25, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 15fce8d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

@Saran440 Saran440 Saran440 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ps-tubtim @OCA-git-bot @AaronHForgeFlow @Saran440 @mariadforgeflow