Addresses issue #408 for macOS. Under macOS, when libusb_cancel_transfer #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transfer is called on one transfer, all transfers on the same endpoint are cancelled. Calling libusb_cancel_transfer on additional transfers on the same endpoint _may_ result in macOS returning kIOReturnAborted. The net result is the bladeRF can no longer be communicated with. The fix to this is to only call libusb_cancel_transfer once in cancel_all_transfers and set the appropriate state for all transfers. Refer to libusb_cancel_transfer documentation for more details.
|
|
|
This pull request has been here for over a year now. Any chances of this getting merged? @rghilduta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #408 for macOS. Under macOS, when
libusb_cancel_transferis called on one transfer, all transfers on the same endpoint are cancelled. Callinglibusb_cancel_transferon additional transfers on the same endpoint may result in macOS returningkIOReturnAborted. The net result is the bladeRF can no longer be communicated with.The fix to this is to only call
libusb_cancel_transferonce in cancel_all_transfers and set the appropriate state for all transfers. Refer tolibusb_cancel_transferdocumentation for more details.https://libusb.sourceforge.io/api-1.0/group__libusb__asyncio.html#ga685eb7731f9a0593f75beb99727bbe54
Using the script from issue #408, I am unable to cause the error anymore.