Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a second instance on the same host doesn't throw an error or exit #547

Open
2 tasks done
voipmeister opened this issue Aug 17, 2024 · 2 comments
Open
2 tasks done

Comments

@voipmeister
Copy link
Contributor

voipmeister commented Aug 17, 2024

Describe the Bug
Not quite a bug (but no feature either I think), but while checking different versions of Node and Enigma I accidentally started a second instance. The second instance wasn't bound to port 8888/tcp ofcourse, but there was no warning message either. Would be nice to have a warning message and exit IMHO.

To Reproduce
Any relevant steps to reproduce the behavior:
Deploy a second installation of Enigma on the same host; start the first instance and the start the second instance.

Desired Behavior
Would be nice to have a warning message and exit IMHO.

Actual Behavior
The second instance isn't bound to port 8888/tcp and there's no warning message either.

Environment

  • I am using Node.js v14.x LTS or higher
  • npm install or yarn reports success
  • Actual Node.js version (node --version): v18.20.4
  • Operating system (uname -a on *nix systems): Linux bbs01 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux (Raspberry Pi 3B)
  • Revision (git rev-parse --short HEAD): 9c0bc88f
  • Any additional relevant information about your setup: None, I think :)
@NuSkooler
Copy link
Owner

@voipmeister There should be errors in your log about binding to ports already in use. Enigma doesn't just panic and exit in this case, however.

@voipmeister
Copy link
Contributor Author

Understood. Would it be possible to provide a little feedback on the console though? Granted, in production you'd not run into this often or easily, but I'm testing with various installs on the same VM and well... You know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants