Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetRunner over SSH off by one issues #414

Open
NuSkooler opened this issue Apr 8, 2022 · 2 comments
Open

NetRunner over SSH off by one issues #414

NuSkooler opened this issue Apr 8, 2022 · 2 comments
Labels

Comments

@NuSkooler
Copy link
Owner

NetRunner (v2.0 beta 22 on Windows x64 as of this writing) reports it's terminal dimensions incorrectly when over SSH -- specifically as 80x48 when 80x25 is expected.

This causes issues with omitting trailing LF's at termHeight when displaying art causing the screen to drop down by one and throw positioning off.

There may be a workaround for this. Will also be reported to g00r00.

@cognitivegears
Copy link
Collaborator

I wonder if this is a timing issue. If NetRunner reports term dimensions before ready, it looks like if some combinations of both window-change and pty are called before we have self.input then we can lose a previous value of cachedTermInfo. I wonder whether its sending multiple values? Unfortunately NetRunner isn't working for me on SSH right now (wrong version of cryptlib maybe) so I can't test this myself.

@cognitivegears
Copy link
Collaborator

Note, I am able to replicate this. Also, I'm not a big fan of Netrunner. 😀 But, as it's a pretty popular terminal I'll try to chase it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants