Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command, deleteCallingCommand acts on a guild-wide basis #4

Open
Nos78 opened this issue May 19, 2019 · 1 comment
Open

New command, deleteCallingCommand acts on a guild-wide basis #4

Nos78 opened this issue May 19, 2019 · 1 comment

Comments

@Nos78
Copy link
Owner

Nos78 commented May 19, 2019

The recently added config.json flag, deleteCallingCommand operates on a server-wide basis, meaning that this changes the behaviour for every guild. This is as intended.

However, the related command, !deletecallingcommand (commands/deletecallingcommand.js) should allow individual guilds to modify this setting individually. If an administrator on server X performs the command, it changes the default behaviour of the bot for all servers!

This is currently not an issue, as MrData is operating on one server only. But this will prove problematic very soon, as v1.1.1 is intended to be rolled out to the discord community.

@Nos78
Copy link
Owner Author

Nos78 commented May 19, 2019

The behaviour needs to operate on a server-by-server basis.

This may need to wait for the guild-settings table to be implemented in the database, or create a settings file for each server and store the flag there.

Alternatively, a collection could be added to the client object, using the guild ID as a key. This would mean that the flag would be reset when the bot is restarted (scheduled maintenance or on restarting after failure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant