From 2ef46cd034d36baa1093931508f612afaa407c45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vincent=20Membr=C3=A9?= Date: Mon, 5 Feb 2024 16:50:56 +0100 Subject: [PATCH] Fixes #24143: When self deployment is enabled, you can still deploy your changes. --- .../normation/plugins/changevalidation/WorkflowService.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change-validation/src/main/scala/com/normation/plugins/changevalidation/WorkflowService.scala b/change-validation/src/main/scala/com/normation/plugins/changevalidation/WorkflowService.scala index f42ceb4e9..75140669b 100644 --- a/change-validation/src/main/scala/com/normation/plugins/changevalidation/WorkflowService.scala +++ b/change-validation/src/main/scala/com/normation/plugins/changevalidation/WorkflowService.scala @@ -131,7 +131,7 @@ object TwoValidationStepsWorkflowServiceImpl { } private def canDeploy(isCreator: Boolean, selfDeployment: () => Box[Boolean]): Boolean = { - val correctActor = selfDeployment().getOrElse(false) || isCreator + val correctActor = selfDeployment().getOrElse(false) || !isCreator correctActor && CurrentUser.checkRights(AuthorizationType.Deployer.Edit) }