Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health messages not handled #616

Open
JulesDommartin opened this issue Jul 9, 2024 · 5 comments
Open

Health messages not handled #616

JulesDommartin opened this issue Jul 9, 2024 · 5 comments
Labels
question Further information is requested

Comments

@JulesDommartin
Copy link
Contributor

Version

4.2.0 (latest)

Ask the question

Hi, I was trying to get health messages, but It seems like the library won't let me override the nil delegate that is set in the init of the localElements.

image This function will automatically remove my ModelDelegate for Health Server.

This is very important for our project to get this Health messages, could you please provide a solution for that problem?

Thanks in advance, and thanks for all of your work!

Relevant log output

GattBearerLog: <- 0x001C5C87818292BA321CBDE26178D44302467F0461073127
2024-07-09 15:23:37.511293+0200 Runner[831:81366] [Network] Network PDU (ivi: 0, nid: 0x1C, ctl: 0, ttl: 8, seq: 38, src: 0033, dst: C000, transportPdu: 0xBDE26178D44302467F04, netMic: 0x61073127) received
2024-07-09 15:23:37.516336+0200 Runner[831:81366] [LowerTransport] Access Message (akf: 1, aid: 0x24, szmic: 0, data: 0x2E51D8FF05233BFBE0) received (decrypted using key: Primary Network Key (index: 0))
2024-07-09 15:23:37.522755+0200 Runner[831:81366] [UpperTransport] Upper Transport PDU (encrypted data: 0x2E51D8FF05, transMic: 0x233BFBE0) received
2024-07-09 15:23:37.526008+0200 Runner[831:81366] [Access] Access PDU (opcode: 0x 4, parameters: 0x00AA0402) received (decrypted using key: Application Key 1 (index: 0))
Default message received
UnknownMessage(opCode: 0x000004, parameters: 00AA0402)
UnknownMessage
@JulesDommartin JulesDommartin added the question Further information is requested label Jul 9, 2024
@philips77
Copy link
Member

Hello,
Indeed, the library does what you say. The plan was to implement all models that require Device Key encryption inside the library, but due to lack of resources we had to switch to other projects. Health models are still in the backlog, but now DFU will be the priority.

As a solution I would recommend importing the library locally, via SPM or CocoaPods, and adding Health client and server delegates like they are for Config and Scenes. We could gladly accept a PR :)

It's vacation period now, so the fastest we could do anything about it would be September-ish, so the above solution is best for you, if technically possible.

@JulesDommartin
Copy link
Contributor Author

Hi @philips77, how are you going ?
Do you have any update on this ? If not, are you planning on doing it ?
It is hard to find the time for us to work on this but if you don't have the time too, we can try.

Thanks in advance.

@philips77
Copy link
Member

philips77 commented Oct 30, 2024 via email

@JulesDommartin
Copy link
Contributor Author

Thanks for your answer, I will probably start implementing it myself and submit a PR in a few times. Good luck with your planning !

@JulesDommartin
Copy link
Contributor Author

#626 Here is the PR for this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants