Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small suggestion: remove ZipFoundation dependency (split libraries) #275

Open
DevAndArtist opened this issue Mar 3, 2019 · 2 comments
Open

Comments

@DevAndArtist
Copy link
Contributor

DevAndArtist commented Mar 3, 2019

Could we remove the dependency for ZIPFoundation? By that I don't mean to completely remote it, but to split the main library into multiple parts, one LITE version that does not have this dependency and FULL that still has it. In our case we simply don't need the zip functionality and carrying around an unused ZIP framework in the app bundle is redundant for us.

This is possible in cocoapods, but I'm not sure how this can be done with cartahge. Maybe RxSwift repository can give us a hint how to set it up (they provide multiple modules from a single repository).

@philips77
Copy link
Member

I understand your point, but there are some buts:

  1. I don't think using Base64 strings is that popular that many would benefit from the split.
  2. I would rather think about having DFU with a simple DFUFirmware class, without the ZipFramework dependency + another module that extends it and allows to use ZIP. I don't know if it's possible.
  3. I have a lot in my backlog right now and this doesn't seem to be important task (just an improvement). So even if it's implemented, it will take long time, so PRs are welcome :)
  4. That would also require us to maintain this modules in the future. I have no idea is it easy or not, never done that. Perhaps some script would solve everything (automated release, etc).

Let's keep the task here. Perhaps it will eventually be resolved.

@DevAndArtist
Copy link
Contributor Author

Well base64 is just our way to hardcode the raw FW data into the app binary, we convert it into Data when required. We might add Firebase support in the future and distribute FW updates through the web which most likely will also avoid zip files.

It's definitely not a super important task but it would remove unnecessary dependency from our project. If I find some time in the next couple of weeks I could provide a PR, but I'm not sure how I can quickly test pods as I probably would need to create a new podspec just for testing.

@philips77 philips77 changed the title Small suggestion for improvement Small suggestion: remove ZipFoundation dependency (split libraries) Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants