-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate the eval command #355
Comments
This is a bit tricky, because you'd need to inspect the file first to check whether there are peptide sequences included in order to know how to instantiate the data loader (annotated MGF or standard MGF). Easier would be the alternative option that adds an |
Yes, --evaluate is fine with me. |
Do we still want to output the sequence results file if the evaluate flag is set? If so I think a good apprach might be to add a boolean argument to Edit: Nevermind, I followed the function calls all the way into the PyLightning library without realizing it. I'll think of another approach. |
Yes, we should output sequencing results if the flag is set. |
The eval command is just like the sequence command except that it requires annotated spectra. We should get rid of it, and then have the program automatically do evaluations if the user provides annotated spectra. If no validation set is provided, the evaluation should be done on the training set. Results can be printed to the log file, as is done currently.
The text was updated successfully, but these errors were encountered: