Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: left hero content displacement fix #213

Conversation

TropicolX
Copy link

@TropicolX TropicolX commented Jan 18, 2023

Closes #88

What new changes did you make? Tick all applicable boxes

  • Added new abbreviation
  • Fixed something in the source code
  • Added a new feature
  • Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.

Added a max-width utility class to the right hero content's list of classes, so it has a max width of 22.5rem. This way, it doesn't expand beyond that width when its content changes and, as a result, displace the left content.

Share a screenshot of new changes

Screenshot 2023-01-18 175106
Screenshot 2023-01-18 175142
Screenshot 2023-01-18 175204

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
abbreve ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 5:01PM (UTC)

@Njong392
Copy link
Owner

Thank you so much for the changes you made. It seems that your PR came with some changes to the package-lock.json file. To prevent future complications on the main branch, it is advisable that you revert these changes. You can check here on how to do that.

@PriyansuMaurya
Copy link
Contributor

PriyansuMaurya commented Jan 20, 2023

Good but it seems still there is a small thing to be fixed --> displacement at the bottom

look here

Screenshot (28)

rec-screen-1.mp4

@Njong392
Copy link
Owner

Oh wow. I didn't catch this on my browser. Thanks for highlighting it @PriyansuMaurya

Can you take a look at that @TropicolX ?

@Njong392
Copy link
Owner

@TropicolX are you still working on this pull request?

@Njong392
Copy link
Owner

I'm sorry but I will have to close this PR. I has been stagnating for a while. Feel free to checkout more issues you may want to work on. Thank you nonetheless for your contribution.

@Njong392 Njong392 closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants