The latest updates on your projects. Learn more about Vercel for Git ↗︎

@reny-pacheco I suggest you improve on the regex for sanitizing inputs cos I don't think the current implementation supports abbreviations with special characters, e.g w/o.

I suggest you use the encodeURIComponent function instead.

Good catch @mathiasayivor , I'll try to use encodeURIComponent. Thank you.

@reny-pacheco is there any update on this?

Hello, apologies for not having an update, you can assign this to another contributor if they want to work on this. Thank you.

@mathiasayivor you mentioned something about certain inputs not being accepted because of the sanitation. Would you have an idea related to this pull request?

@mathiasayivor you mentioned something about certain inputs not being accepted because of the sanitation. Would you have an idea related to this pull request?

Yeah

encodeURIComponent is the best option for sanitizing user inputs, since it's used in the CLI for encoding.

I'd also recommend using the encodedAbbrMappings.json in addition to encodeURIComponent to be sure the searched slang doesn't exist before sending the final result to the user.

Demo below:

search -> sanitize user input (`encodeURIComponent`)
                                                   |
                                          search abbrev -> found result? -> show slang definition
                                                   |
                                             No result?
                                                   |
                           check encodedAbbrMappings.json -> found result? -> show slang definition
                                                   |
                                             No result?
                                                   |
                           Display Result not found error

I see... kind of hahaha. Do you want to go for it @mathiasayivor ? Maybe contribute to @reny-pacheco fork.

I see... kind of hahaha. Do you want to go for it @mathiasayivor ? Maybe contribute to @reny-pacheco fork.

Sure... But I'm not sure if I have write access to @reny-pacheco's fork...

Perhaps I should just create a new PR by copying @reny-pacheco's changes and adding changes?

Sure... But I'm not sure if I have write access to @reny-pacheco's fork...

Hi @mathiasayivor , If you doesn't have access, I can give you access to the fork if its possible.

Sure @reny-pacheco ... That'd be great!

Sure @reny-pacheco ... That'd be great!

@mathiasayivor , I've already added you as contributor to the fork, can you confirm that?

Sure @reny-pacheco ... That'd be great!

@mathiasayivor , I've already added you as contributor to the fork, can you confirm that?

Seen

Alright fellas, I think we're good to go!
@Njong392 @reny-pacheco @adropofilm reviews are welcomed.

Hi @mathiasayivor , I suggest to add a guard clause in line 31 of form.jsx file, to prevent fetching of encodedAbbrMappings if search field is empty. I found out that if you click submit with empty value. It still fetch the data.

Suggestion:

const fetchData = async (query) => {
   if(!userInput.trim()) {
      return
    } 
    let mappings;
    ...
    ...

Sure...

LGTM, Thanks @mathiasayivor 😃

Yikes... the whole code became something different haha. Still trying to wrap my head around it. But... when the user enters a slang that doesn't exist, it just says "some connection error occurs". Shouldn't it warn the user that the slang doesn't exist and they could raise an issue as before?

Yikes... the whole code became something different haha. Still trying to wrap my head around it. But... when the user enters a slang that doesn't exist, it just says "some connection error occurs". Shouldn't it warn the user that the slang doesn't exist and they could raise an issue as before?

This works on the local dev env:

The error you're getting is the expected behaviour, since the server is responding with 200 status instead of 404.

I think the error you're getting is an issue with how vercel's routing works,

The expected response, in this case, is 404 but the server is returning 200 with HTML as content type, hence the app is unable to parse HTML as JSON, thence the error.

I see. Is there a fix to this? Or we just blame it on vercel 😂

Hi @mathiasayivor , on my fork, I created a branch named simplified-fetch that may fix 404 issue , since previously we are explicitly comparing the status code. Maybe you can check it since you have already access on my fork.

It only fetch one endpoint and still gives the correct abbreviation.
But we still need to check if the status code is correct(404) if there is no abbreviation once deployed.

I see. Is there a fix to this? Or we just blame it on vercel 😂

Perhaps do additional checks(i.e ensuring response is a valid JSON) if the response status is 200.

I am so lost on this pull request right now, so I am putting it off for a bit. Thank you @mathiasayivor and @reny-pacheco for the progress on this!