oversteer: fix udev rule package paths #364728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
iamtimmy
force-pushed
the
fix/oversteer
branch
3 times, most recently
from
0120813 to
5afc78b
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
iamtimmy
force-pushed
the
fix/oversteer
branch
from
5afc78b to
fa5103c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
10.rebuild-darwin: 0
Because of the other udev rules detailed above (Gosh you're fast). Should I add --replace-fail to the /bin/sh substitution? That one does work. |
Yes please!
Thanks 😁 |
iamtimmy
force-pushed
the
fix/oversteer
branch
from
fa5103c to
bd7d1ad
Compare
philiptaron
requested changes
Dec 13, 2024
philiptaron
changed the title
iamtimmy
force-pushed
the
fix/oversteer
branch
from
bd7d1ad to
9de7767
Compare
philiptaron
reviewed
Dec 13, 2024
With the following in a nixosModule context `services.udev.packages = with pkgs; [ oversteer ];` A `nixos-rebuild` fails with `contains references to /usr/bin/evdev-joystick`
iamtimmy
force-pushed
the
fix/oversteer
branch
from
9de7767 to
41135a0
Compare
|
updated with suggested changes :) |
philiptaron
approved these changes
Dec 13, 2024
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following in a nixosModule context
services.udev.packages = with pkgs; [ oversteer ];anixos-rebuildfails to apply udev rules withcontains references to /usr/bin/evdev-joystickAdding the
linuxConsoleToolspackage as a dependency was needed to provide theevdev-joystickbinary.I have not been able to test if the evdev rules work for the Fanatec hardware. I was able to verify that the path in the build output is now compliant.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.