Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forgejo: 9.0.2 -> 9.0.3, forgejo-lts: 7.0.11 -> 7.0.12 #364715

Merged
merged 2 commits into from
Dec 12, 2024
Merged

forgejo: 9.0.2 -> 9.0.3, forgejo-lts: 7.0.11 -> 7.0.12 #364715

merged 2 commits into from
Dec 12, 2024
+7 −7

Conversation

emilylange
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@emilylange emilylange added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically labels Dec 12, 2024
evanrichter
evanrichter approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@evanrichter evanrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded from 7.0.11 to 7.0.12 with these hashes and everything seems to work great still

@NyCodeGHG
Copy link
Member

tests pass on x86_64-linux

# nix-build -A forgejo.tests -A forgejo-lts.tests
/nix/store/3gkbdf52ar6622lfp5d80xsnjy5wv97j-vm-test-run-forgejo-mysql
/nix/store/wrwvmjnmy8n2cbb06ffy6x0ggqi45sy8-vm-test-run-forgejo-postgres
/nix/store/i9fdaxmfk8i190m78rzpnqdf60gqiv4d-vm-test-run-forgejo-sqlite3
/nix/store/2pfjpzmmx4zmjpqai9b9bwwlia2s8fh1-vm-test-run-forgejo-mysql
/nix/store/xczhbr3qx8kn81i9kvlwqry7s7jkd0i2-vm-test-run-forgejo-postgres
/nix/store/wkwmq37k14w5rr33sam1hagprpcadlj0-vm-test-run-forgejo-sqlite3

@adamcstephens
Copy link
Contributor

we'll use the borg while it exists :)

@ofborg build forgejo.passthru.tests forgejo-lts.passthru.tests

@adamcstephens
Copy link
Contributor

Since this is a security fix we'll want to update the 7.x on 24.05

@adamcstephens adamcstephens merged commit c3b6e73 into NixOS:master Dec 12, 2024
27 of 30 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 12, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 12, 2024
Merged
1 task
@emilylange emilylange deleted the forgejo branch December 12, 2024 23:53
@emilylange emilylange mentioned this pull request Dec 13, 2024
Merged
13 tasks
@emilylange
Copy link
Member Author

Since this is a security fix we'll want to update the 7.x on 24.05

Manual backport in #364761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyCodeGHG NyCodeGHG NyCodeGHG approved these changes

@evanrichter evanrichter evanrichter approved these changes

@bendlas bendlas Awaiting requested review from bendlas

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

@urandom2 urandom2 Awaiting requested review from urandom2

@pyrox0 pyrox0 Awaiting requested review from pyrox0

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilylange @NyCodeGHG @adamcstephens @evanrichter