Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waylyrics: 0.3.16 -> 0.3.20 #364626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

waylyrics: 0.3.16 -> 0.3.20 #364626

wants to merge 1 commit into from
+7 −3

Conversation

mokurin000
Copy link

@mokurin000 mokurin000 commented Dec 12, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 12, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 12, 2024
@mokurin000 mokurin000 changed the title waylyrics(fix): allow git dep in Cargo.lock waylyrics: v0.3.16 -> v0.3.20 Dec 13, 2024
@ofborg ofborg bot requested review from Aleksanaa and ShadowRZ December 13, 2024 09:34
NickCao
NickCao reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be waylyrics: 0.3.16 -> 0.3.20, otherwise LGTM.

@mokurin000
Copy link
Author

Commit message should be waylyrics: 0.3.16 -> 0.3.20, otherwise LGTM.

thanks, will force-push later

@Aleksanaa Aleksanaa changed the title waylyrics: v0.3.16 -> v0.3.20 waylyrics: 0.3.16 -> 0.3.20 Dec 13, 2024
@Aleksanaa
Copy link
Member

@ofborg build waylyrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

@ShadowRZ ShadowRZ ShadowRZ approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mokurin000 @Aleksanaa @NickCao @ShadowRZ @NixOSInfra