-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ps3-disc-dumper: 3.2.3 -> 4.2.5, .NET 6 -> 9 #361506
Conversation
06f0a8f
to
c3ea9e7
Compare
c3ea9e7
to
c61c752
Compare
40311f6
to
3944510
Compare
|
Also, please squash all of this into a single commit with the proper title |
666c63e
to
3e76df8
Compare
I've edited the previous commits, usually I like keeping every small meaningful change in a separate commit. I'm open to squashing all the refactor commits into a single one if that's preferred in nixpkgs, but for good bisecting and reviewing experience I'd like to keep nixfmt, package update and general refactor changes in separate commits |
I don't remember seeing something similar in other nixpkgs PRs so I'd err on the side of caution and request that they be squashed, however if you'd like to request a second opinion from another nixpkgs member or just ignore my nit I have no problems with it. |
I prefer the current commit style, but again if there's a stronger opinion on how it should be changed let me know. 10 days have passed and @evanjs hasn't responded whether the replacement of the CLI project to a GUI one is acceptable (as decided by upstream where an issue was raised about this). If anyone reports the same in nixpkgs we can add the CLI project that is pinned to an older, non-maintained version. For now I think this PR is ready to merge. |
I personally prefer the smaller commits, as long as each one is meant work on its own. |
I'm thinking we shouldn't backport this to 24.11, even though the package is marked insecure there. If we could get the old one building with a new SDK, maybe we could backport that part, but I'm guessing that wouldn't be easy. |
3e76df8
to
47b8baa
Compare
47b8baa
to
c5caab6
Compare
I separated the .NET version bump and package version bump into 2 commits, both seems to work. |
Nice one. Thanks |
|
Tracking: #326335
A big change since the previous version is the removal of the CLI project (13xforever/ps3-disc-dumper@a88facc). Now we are building the GUI project made in Avalonia.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
) only checked whether the GUI opensAdd a 👍 reaction to pull requests you find important.