Sudden renames cause warnings in out-of-tree modules #157667
Labels
0.kind: bug
Something is broken
6.topic: module system
About "NixOS" module system internals
6.topic: release process
Issues or PRs which are parts of the NixOS release process
6.topic: user experience
Describe the bug
The current process for renames puts out-of-tree modules in a situation where users are confronted with warnings they can't solve, and neither can the maintainers.
Steps To Reproduce
Steps to reproduce the behavior:
cachix use --nixos
start emitting warningsExpected behavior
All generated warnings can be resolved by the user.
Suggested process:
cachix use --nixos
start emitting warningsTo facilitate the process, we can add an argument to functions like
mkRenamedOptionModule
to indicate the first release that will support the change. We'll maintain two (hidden?) version numbers that we update during the NixOS release process. For example, at the time of writing, the only supported stable version is 21.11 and 22.05 has not been released yet.To enable warnings on
master
, we only need to updateoldestSupportedRelease
.Interestingly, we'll be deprecating functions that deprecate without
sinceRelease
. Sounds meta, but it's not complicated. It just means that some old style deprecations will slip through the net for some more time.Screenshots
Additional context
nix-community/home-manager#2371 (comment)
#139075 (also a big one, but no complaints yet)
Notify maintainers
@jonringer @rycee @infinisil
The text was updated successfully, but these errors were encountered: