From 5b4d838e436555283587526f891ebee4ff97d6c0 Mon Sep 17 00:00:00 2001 From: David McFarland Date: Sun, 27 Oct 2024 13:43:47 -0300 Subject: [PATCH] treewide: remove uneccessary uses of dotnetCorePackages.combinePackages --- pkgs/by-name/fs/fsautocomplete/package.nix | 9 ++------- pkgs/by-name/na/naps2/package.nix | 14 +++++++++++++- .../space-station-14-launcher.nix | 3 +-- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/pkgs/by-name/fs/fsautocomplete/package.nix b/pkgs/by-name/fs/fsautocomplete/package.nix index f4e3b7d743927..37b85a730f79d 100644 --- a/pkgs/by-name/fs/fsautocomplete/package.nix +++ b/pkgs/by-name/fs/fsautocomplete/package.nix @@ -26,13 +26,8 @@ buildDotnetModule (finalAttrs: rec { --replace-fail TargetFrameworks TargetFramework \ ''; - dotnet-sdk = - with dotnetCorePackages; - combinePackages [ - sdk_8_0 - sdk_9_0 - ]; - dotnet-runtime = dotnetCorePackages.sdk_9_0; + dotnet-sdk = dotnetCorePackages.sdk_8_0; + dotnet-runtime = dotnetCorePackages.sdk_8_0; projectFile = "src/FsAutoComplete/FsAutoComplete.fsproj"; executables = [ "fsautocomplete" ]; diff --git a/pkgs/by-name/na/naps2/package.nix b/pkgs/by-name/na/naps2/package.nix index 93161f889efd8..ad5241cf2ee8e 100644 --- a/pkgs/by-name/na/naps2/package.nix +++ b/pkgs/by-name/na/naps2/package.nix @@ -26,7 +26,19 @@ buildDotnetModule rec { executables = [ "naps2" ]; - dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_6_0 sdk_8_0 ]; + dotnet-sdk = + with dotnetCorePackages; + sdk_8_0 + // { + inherit + (combinePackages [ + sdk_8_0 + sdk_6_0 + ]) + packages + targetPackages + ; + }; dotnet-runtime = dotnetCorePackages.runtime_8_0; selfContainedBuild = true; runtimeDeps = [ diff --git a/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix b/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix index 9ad8c3b335f60..c5b1da7f57c88 100644 --- a/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix +++ b/pkgs/games/space-station-14-launcher/space-station-14-launcher.nix @@ -55,8 +55,7 @@ buildDotnetModule rec { updateScript = ./update.sh; }; - # SDK 6.0 required for Robust.LoaderApi - dotnet-sdk = with dotnetCorePackages; combinePackages [ sdk_8_0 sdk_6_0 ]; + dotnet-sdk = dotnetCorePackages.sdk_8_0; dotnet-runtime = dotnetCorePackages.runtime_8_0; dotnetFlags = [