Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to infinite max_history_tokens to be backward compatible. #11

Closed
NirantK opened this issue Aug 2, 2023 · 2 comments
Closed

Default to infinite max_history_tokens to be backward compatible. #11

NirantK opened this issue Aug 2, 2023 · 2 comments

Comments

@NirantK
Copy link
Owner

NirantK commented Aug 2, 2023

We should default to infinite max_history_tokens to be backward compatible.

Originally posted by @NirantK in #8 (comment)
@NirantK NirantK changed the title We should default to infinite max_history_tokens to be backward compatible. Default to infinite max_history_tokens to be backward compatible. Aug 2, 2023
@adivik2000
Copy link
Contributor

Backward compatible as in have a list of all the messages in one list and that is trimmed based on the tokens given?

@NirantK
Copy link
Owner Author

NirantK commented Aug 4, 2023

Do not trim the Conversation by default at all. That is the existing behavior — we don't trim.

@adivik2000 adivik2000 mentioned this issue Aug 8, 2023
Merged
@NirantK NirantK closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adivik2000 @NirantK