Non-ASCII Characters

[fonkadelic]

Seems like the parser eats non-ASCII Characters outside of the tokens.

For example:
@"This is *italic*, **bold**, änd ***böld italic***."

becomes

This is italic, bold, nd _böld italic_.

[myell0w]

This is fixed in my pull request, see commit 4e649d4.

[fonkadelic]

@myell0w Perfect! Thanks for the fix.

[fonkadelic]

@myell0w Just found another issue which is related to the problem above.

The parser truncates links if the string includes non-ascii chars:

@"Änd ä link tö githüb: http://www.github.com"

becomes

Änd ä link tö githüb: http://www.github.

[myell0w]

thanks for reporting! is this due to my pull request or did that happen before as well?

Sent from iPhone

Am 03.05.2013 um 10:28 schrieb Bernhard Loibl [email protected]:

@myell0w Just found another issue which is related to the problem above.

The parser truncates links if the string includes non-ascii chars:

@"Änd ä link tö githüb: http://www.github.com"

becomes

Änd ä link tö githüb: http://www.github.

—
Reply to this email directly or view it on GitHub.

[fonkadelic]

@myell0w I'm pretty sure it has nothing to do with your pull request. The problem only occours if the string inlcudes non-ascii chars.

I also tried another utf-8 pattern (http://flex.sourceforge.net/manual/Identifiers.html#Identifiers) without success.

[AlexDenisov]

@fonkadelic, I've faced with the same problem, here is solution #12

[fonkadelic]

@AlexDenisov hmm... unfortunately the problem still persists for me.
Add the following link to LinksViewController and you can see the problem:
@"Änd ä link tö githüb: http://www.github.com"

[AlexDenisov]

@fonkadelic, have you tried it on my fork? Cause for me it works well, also it fixes issues in my project.

[AlexDenisov]

@fonkadelic, got it. I thought that we talk about line cut, but just realized that I have missed non-ASCII characters too. That's sad...

[fonkadelic]

@AlexDenisov ah... you're right... your PR fixes the truncated lines bug. I don't have recognized this at first sight.
The problem with non-ASCII chars has already been fixed by @myell0w in this commit myell0w/NSAttributedStringMarkdownParser@4e649d4

[AlexDenisov]

@fonkadelic, yeah, thanks for the link.

[haemi]

how's this working now? I don't find the markdown.grammer-File in this project...