Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtg wiki runs on an outdated version #32

Closed
yandere-sliver opened this issue Jun 20, 2018 · 7 comments
Closed

mtg wiki runs on an outdated version #32

yandere-sliver opened this issue Jun 20, 2018 · 7 comments

Comments

@yandere-sliver
Copy link

Hi,

I looked up what version we are running in the mtg wiki and realized that ours is outdated.
I asked the gamepedia stuff if they could do an updated and I was told that there is still an important issue unresolved in the pull request.

Thank you very much.

@NilsEnevoldsen
Copy link
Owner

They're referring to pull request #26 (deck downloading), which they've patched into their build but I haven't merged yet. I think I'll work on it now.

There's also issue #22, for which which I still haven't found a workaround despite trying every once in a while. I kinda didn't want to push out the next version until it was fixed, but maybe it's just not to be. ☹️

@yandere-sliver
Copy link
Author

I think #26 is the issue they were talking about.

Usually we are quite keen to have the newest version of the an extension. So if you fix #22 somewhere in the future, I will kick someone to update again. :)

Thank you very much.

@NilsEnevoldsen
Copy link
Owner

I've been doing some work locally this week. I should have something by end of next week. After a lot of agonizing, I'm pursuing a js-based downloading/exporting approach, which I think is more elegant. I just need to make sure I'm generating formats to spec. Thanks for bearing with me.

@valeryan
Copy link

@yandere-sliver, @NilsEnevoldsen, I have reapplied the gamepedia patch to the current code and we will be pushing out an update soon to the MTG site. Whenever Nils updates with his own download option we will remove our patch. But you guys should be good to go for a bit in a bit. :)

@NilsEnevoldsen
Copy link
Owner

Oh, and #22 just looks surprisingly difficult to fix. It's annoying. :-/

@valeryan
Copy link

valeryan commented Jul 9, 2018

@NilsEnevoldsen @yandere-sliver We pushed out an update to mtg wiki so it is now on the current version of ScryfallLinks.

@yandere-sliver
Copy link
Author

I would say this can be closed. We are up to date almost all important features except for deck export are online. The rest would be nice to have, but everything is very functional for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants