-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support <cards> and <cs> #12
Comments
#21 resolves this. |
Hm, why isn't this working on the test wiki? Probably a dumb mistake I'm making. |
Intend use case is something like this:
|
Right, but it's not working here? http://ec2-34-226-122-61.compute-1.amazonaws.com/Time_Spiral |
Did you merge in my changes from #21? Its working on my local wiki running my branch. |
Now that Im looking over the code for MTGSCards, I think my PR may not be 100% correct intended functionality either. Let me go look over my PR again. |
Oh, I found my dumb mistake. I was updating the extension in the wrong way. It works now. But I'll wait to merge until you give me the go-ahead. |
Can you also check that you're not adding an extra line break at the end? When you're ready, I'll merge your PR, fix some of my own Grunt warnings, bump the version, and ask Scryfall (again) for a final green light, and then we should be good to go as far as I'm concerned. |
Updated. There is some edge-case stuff that may not be covered still -- but the MTGSCards extension is so old and undocumented that its sort of hard to figure out exactly what some stuff is trying to accomplish. I think this is a good enough implementation to cover 99% of use cases. |
Closed by #21. |
You have the green light from Scryfall, @applehat. Do you have a Discord handle? |
Acutally, Scryfall asks that I change the |
And that's done in 1.0.1. |
For backwards compatibility. Not sure what expected behavior is, tbh. Maybe we don't need to support this?
https://mtg.gamepedia.com/Help:Card_tags
The text was updated successfully, but these errors were encountered: