Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WearOS complication not working with G7 #3543

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nielsvanvelzen
Copy link
Contributor

This should fix #303. The G7 does not report as "G7 Native" like the G5/G6 does. Instead it just reports as "G7" causing the ListenerService abomination to fail when saving new values.

Related: #3220 is the pr introducing this change

@Navid200
Copy link
Collaborator

Do you know the purpose of that conditional? I don't.
I have no experience with WearOS?
Why is non-native mode excluded? I mean what if someone is using a G5 in non-native mode? Why is that not qualified to be shown with WearOS?

I can see that your proposed change may fix a problem. But, I'd like to know the reason for a line before changing it.
I mean if there is no reason to have that restriction, another solution would be to remove it altogether. Otherwise, we may possibly have to make this fix every time a new device is added to xDrip.

@jamorham
Copy link
Collaborator

@nielsvanvelzen Can you confirm that you have tested this change and it is working? thanks

@nielsvanvelzen
Copy link
Contributor Author

Unfortunately it's almost impossible to test the wear app without rebuilding the mobile app too. The change is easy enough to verify the working by looking at the changes from the linked PR, the logs from the linked issue and the changes in this one.

@jamorham
Copy link
Collaborator

Ok we can try this out

@jamorham jamorham merged commit 994b0ca into NightscoutFoundation:master Jun 28, 2024
1 check passed
@nielsvanvelzen nielsvanvelzen deleted the wear-g7 branch June 28, 2024 09:10
@nielsvanvelzen
Copy link
Contributor Author

Updated to the latest nightly and I can confirm everything is working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complication displays permanently null null ()
3 participants