No G7 hard reset #3238
Merged
No G7 hard reset #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamorham
reviewed
Dec 13, 2023
| } else { | ||
| if (FirmwareCapability.isTransmitterG5(getTransmitterID()) || FirmwareCapability.isTransmitterTimeTravelCapable(getTransmitterID()) || FirmwareCapability.isTransmitterModified(getTransmitterID())) { // Devices that can be hard reset only | ||
| DexResetHelper.offer("Your transmitter clock has stopped or never started. Do you want to hard reset it?"); | ||
| } else { // Everything else - future devices will be here. If a future device can be hard reset, they should be added to the true (other) side. |
There was a problem hiding this comment.
The if and else clauses both seem to be the same, is this correct?
There was a problem hiding this comment.
I'm sorry about that and thanks.
Corrected now
jamorham
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR (#3113) 2 months ago improved the logic.
But, it was not future-proof.
Now, with G7 added, it may offer to hard reset a G7.
This PR changes the logic from negative to positive. There are two outcomes:
1- G7 will not be offered a hard reset.
2- In the future, any new devices added, by default will not be offered a hard reset.
Of course if we add a new device in the future that can be hard reset, we will still need to change this to make it complete. But, there is no way to predict the future. However, I would say it is more likely that future devices will not be hard reset capable.