-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Optifine Cape #10
Comments
Hey, sorry for not answering this sooner. Originally I wasn't going to implement optifine support as I don't want to limit things to a single mod.
Regarding this, I did go ahead and check the image resolutions and the result was this:
The capes have different resolutions but the aspect ratio is consistent within themselves. However, the resolution is different from the Minecraft cape images and will definitely require some extra logic to handle that. I did see the PR #11, but so far I am thinking of implementing the support in a different way, as I am brainstorming a different system that would allow to custom cape support without adding specific logic in the code itself. Oh, and caching logic might need to be changed as well to account for the capes. In the following days, I will (hopefully) implement a proper system for custom capes. |
I think I can change OptifineCape to CustomCape on my PR and provide the option to modify the cape texture url in the configuration file, just like the mojang configuration To support optifine cape resolution just add a customize resize option or provide a resize mode for optifine cape |
Reopening this since the issue itself (supporting optifine and other capes) isn't fully implemented yet. The commit e621000 introduced a way to render skins with any cape, as long as it matches the expected aspect ratio (2:1), but only for POST requests (these essentially let you have custom skins in general. |
with parameter
?optifine=true
will render optifine cape if player have itCape API: https://optifine.net/capes/.png
Example Links:
https://optifine.net/capes/Notch.png
https://optifine.net/capes/BadBoyHalo.png
I think default cape / custom (banner) cape are not same type (with different size)
The text was updated successfully, but these errors were encountered: