Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting files outside the App results in impossible to deploy files #2324

Open
Tracked by #2311
Al12rs opened this issue Nov 28, 2024 · 1 comment
Open
Tracked by #2311

Deleting files outside the App results in impossible to deploy files #2324

Al12rs opened this issue Nov 28, 2024 · 1 comment
Labels
Bug Something isn't working Epic: Apply-ingest

Comments

@Al12rs
Copy link
Contributor

Al12rs commented Nov 28, 2024

Outline:

Deleting files outside the app results in irreversible ban of the file from deployment.
Only solution is to abandon loadout and restart from scratch.

Problem:

If you delete a file outside the app, the deletion gets picked up by the app and placed in the hidden Overrides mod.

That deletion entry will from then on prevent any file with the same destination from being deployed.
The deletion entry itself can't be removed, cleared, or in any way be interacted with. It is also in no way visible to the users.

The only way a user has to allow the app to deploy files to that destination again is by starting from scratch, abandoning their loadout with all their mods.

This experience is horrible for users, that don't know why some files are not getting deployed. It is also horrible for giving support as users will rarely be able to tell whether they have deleted some file at some point or not.

Steps:

To reproduce:

  • Install a BG3 mod with a pak file
  • Delete the BG3 pak file from BG3 %localappdata%\Larian Studios\Baldur's Gate 3\Mods.
  • Attempt to install the same pak file from the app again
  • pak file will not be deployed
  • pak file is now cursed
@Al12rs Al12rs added Bug Something isn't working Epic: Apply-ingest labels Nov 28, 2024
@Al12rs Al12rs added this to MVP Nov 28, 2024
@LukeNexusMods
Copy link
Collaborator

LukeNexusMods commented Dec 2, 2024

Steps for solution:

  • When there is an outside deletion, we add a reified delete to Overrides mod.
  • If the reified delete already exists, we do nothing. Currently we add a second delete which is a problem.
  • If an outside file addition appears that was previously deleted, we remove the reified delete from Overrides, and add the file to overrides if it differs from the winning mod. (Or let game specific code decide where to put it, e.g. SDV config files).

The above does not help if the user is attempting to add the file back from within the app.
To solve that, users need the ability to edit the contents of Override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Epic: Apply-ingest
Projects
Status: No status
Development

No branches or pull requests

2 participants