Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go minor revision specification #26

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

francesconi
Copy link
Contributor

Specifying a Go minor revision forces all importers of the package to upgrade as well. Since I don't see any crucial benefit in enforcing this, I propose removing the requirement.

@scottm-blackmagicdesign

Yes, please accept this PR. It is not the end of the world, but our CI is not yet updated to use Go 1.22.5 and this line causes an error due to this unnecessary requirement.

@francesconi
Copy link
Contributor Author

francesconi commented Aug 21, 2024

@scottm-blackmagicdesign you can either upgrade to go 1.23 or temporarily add the following line to your go.mod file:

replace github.com/Netflix/go-env v0.0.1 => github.com/francesconi/go-env v0.0.0-20240809075706-245c4bde4d9a

@scottm-blackmagicdesign

Thanks. We already have that, it just took me a little too long (😓) too understand why go mod tidy kept changing our Go language version to 1.22.5 after I had updated our dependencies. Go changed the requirements with 1.21+.

@patricksanders
Copy link
Contributor

Sorry for the trouble folks!

@patricksanders patricksanders merged commit e66d55a into Netflix:master Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants