Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in dialclient discvoery failures #35

Open
honglh opened this issue Sep 3, 2020 · 0 comments
Open

Issue in dialclient discvoery failures #35

honglh opened this issue Sep 3, 2020 · 0 comments

Comments

@honglh
Copy link

honglh commented Sep 3, 2020

  1. the ssdp_search sets the MX value to 10, allowing the device to have upto 10 seconds to respond. Yet, the RESPONSE_TIMEOUT is set to 5 seconds. The wait loop may exit too early.

  2. socket descriptors and wait time should be reset on every select() call

  3. In ssdp_msearch response, the LOCATION header field is case_insensitive, thus checking against LOCATION may not work all the time (depends on the DIAL server impl). See the spec here where it states

....header fields appearing .... Field names are not case sensitive. 

Please see PR 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant