Typography component #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagarajnetcentric
requested changes
Jan 31, 2024
|
|
||
| export interface HeadingProps { | ||
| level: 'h1' | 'h2' | 'h3' | 'h4' | 'h5'; | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
The property children refers multiple elements but it can be defined as text and the type can be string.
There was a problem hiding this comment.
But I'm thinking that if we need to add, for example, a span tag around some of the text for whatever reason, this can be done. Plus it simulates the original heading and paragraph tags
<Heading level="h1">Some <span className="color-red">text</span></Heading>
| export interface TextProps { | ||
| size?: 'default' | 'small' | 'tiny'; | ||
| weight?: 'regular' | 'bold'; | ||
| children: React.ReactNode; |
alexiscoelho
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Heading and Text component