Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust index node name (again) #769

Closed
kwin opened this issue Oct 21, 2024 · 2 comments · Fixed by #772
Closed

Adjust index node name (again) #769

kwin opened this issue Oct 21, 2024 · 2 comments · Fixed by #772
Milestone

Comments

@kwin
Copy link
Member

kwin commented Oct 21, 2024

The guidelines have been clarified meanwhile in https://experienceleague.adobe.com/en/docs/experience-manager-learn/foundation/development/understand-indexing-best-practices#fully-custom-index on how a fully custom index name should look like:

<prefix>.<customIndexName>-<version>-custom-<customVersion>

Our index name does not comply with that: https://github.com/Netcentric/accesscontroltool/blob/develop/accesscontroltool-oakindex-package/src/main/jcr_root/_oak_index/repACL-custom-1.xml

@kwin
Copy link
Member Author

kwin commented Oct 21, 2024

The last update was in the context of #550

@kwin
Copy link
Member Author

kwin commented Oct 21, 2024

Proposed new name: actool.repACL-1-custom-1

@ofarganc ofarganc linked a pull request Dec 4, 2024 that will close this issue
@kwin kwin closed this as completed in d33966c Dec 5, 2024
@kwin kwin closed this as completed in #772 Dec 5, 2024
@kwin kwin added this to the 3.4.1 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant