Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PRIVACYIDEA_CONFIGFILE environment variable #69

Open
plettich opened this issue May 7, 2019 · 2 comments
Open

Respect PRIVACYIDEA_CONFIGFILE environment variable #69

plettich opened this issue May 7, 2019 · 2 comments

Comments

@plettich
Copy link
Collaborator

plettich commented May 7, 2019

Currently, the pi-appliance tool uses a privacyIDEA config file different from /etc/privacyidea/pi.cfg if it is passed with parameter -f.

@fredreichbier
Copy link
Contributor

Ouh, good point, the handling of config files is a bit problematic at the moment.

I think our "privacyIDEA admins" configuration menu respects PRIVACYIDEA_CONFIGFILE, but does not respect -f.

Our "privacyIDEA loglevels" configuration menu respects -f, but not PRIVACYIDEA_CONFIGFILE.

And whenever we call pi-manage in a subprocess, we respect neither -f nor PRIVACYIDEA_CONFIGFILE :-)

@cornelinux
Copy link
Member

Hontestly: I would remove the -f option. This was from a time, when the idea was to keep the pi-appliance flexible. But honestly, it is used in a very specific environment where we always know that the config file will be at /etc/privacyidea/pi.cfg.
So I simply would remove this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants