Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Improved drink name extraction/matching #82

Open
NeonDaniel opened this issue Sep 19, 2024 · 0 comments
Open

[FEAT] Improved drink name extraction/matching #82

NeonDaniel opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement help wanted

Comments

@NeonDaniel
Copy link
Member

Objective

Current parsing contains hard-coded strings in English and is generally imperfect. Finding a drink in the database also returns some improper substring matches.

Initial Implementation Requirements

  • Refactor input normalization to use resource files for any hard-coded strings (OvosCommonQuery noise word removal might be relevant)
  • Update search results to toss unlikely substrings (i.e. "ink" drink matching "think" in the input)

Other Considerations
@NeonDaniel NeonDaniel added enhancement triage New issue needs review help wanted and removed triage New issue needs review labels Sep 19, 2024
@NeonDaniel NeonDaniel moved this to Other Helpful Tasks in Community Projects Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
Community Projects
Status: Other Helpful Tasks
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeonDaniel