Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deprecated imports in ovos-utils 0.1.0 #170

Closed
mikejgray opened this issue Apr 26, 2024 · 2 comments
Closed

[BUG] Deprecated imports in ovos-utils 0.1.0 #170

mikejgray opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mikejgray
Copy link
Contributor

Description

❯ neon-audio run
2024-04-25 23:32:27.402 - neon-utils - neon_utils.configuration_utils:get_config_dir - WARNING - Deprecation version=2.0.0. Caller=neon_audio.cli:59. Use `ovos_config.locations.get_xdg_config_save_path` directly
2024-04-25 23:32:27.405 - neon-utils - neon_utils.configuration_utils:_validate_config_env:535 - INFO - NEON_CONFIG_PATH=/Users/Mike/.config/neon
2024-04-25 23:32:27.405 - neon-utils - neon_utils.configuration_utils:_validate_config_env:539 - WARNING - NEON_CONFIG_PATH set, updating XDG_CONFIG_HOME to /Users/Mike/.config
2024-04-25 23:32:27.406 - neon-utils - neon_utils.packaging_utils:get_neon_core_root - WARNING - Deprecation version=2.0.0. Caller=neon_utils.configuration_utils:473. Use system modules to locate packages and resources
2024-04-25 23:32:28.237 - neon-utils - neon_utils.configuration_utils:_init_ovos_conf:512 - ERROR - Failed to override mycroft.configuration: cannot import name 'play_acknowledge_sound' from 'ovos_utils.sound' (/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/ovos_utils/sound.py)
Traceback (most recent call last):
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/bin/neon-audio", line 8, in <module>
    sys.exit(neon_audio_cli())
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_audio/cli.py", line 60, in run
    from neon_audio.__main__ import main
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_audio/__main__.py", line 39, in <module>
    from neon_audio.service import NeonPlaybackService
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_audio/service.py", line 35, in <module>
    from neon_audio.tts import TTSFactory
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_audio/tts/__init__.py", line 34, in <module>
    from neon_audio.tts.neon import TTS, WrappedTTS
  File "/Users/Mike/Library/Caches/pypoetry/virtualenvs/neon-mac-sv8wqWXe-py3.10/lib/python3.10/site-packages/neon_audio/tts/neon.py", line 41, in <module>
    from ovos_utils.enclosure.api import EnclosureAPI
ModuleNotFoundError: No module named 'ovos_utils.enclosure'

A number of imports have been deprecated in ovos-utils 0.1.0, both with and without replacement, and need to be resolved before Neon will work with that codebase.

Steps to Reproduce

No response

Relevant Code

No response

Other Notes

No response

@mikejgray mikejgray added the bug Something isn't working label Apr 26, 2024
@NeonDaniel NeonDaniel changed the title [BUG] [BUG] Deprecated imports in ovos-utils 0.1.0 May 15, 2024
@NeonDaniel NeonDaniel self-assigned this May 15, 2024
@NeonDaniel NeonDaniel moved this to In Progress in Community Projects May 15, 2024
@NeonDaniel
Copy link
Member

#169 #171 and #172 contribute to this

@NeonDaniel
Copy link
Member

No deprecated imports remaining

@github-project-automation github-project-automation bot moved this from In Progress to Done in Community Projects May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants