Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArbField, AcbField, RealField, ComplexField don't implement isapprox #1877

Open
lgoettgens opened this issue Oct 1, 2024 · 2 comments
Open

Comments

@lgoettgens
Copy link
Collaborator

This is required by the AbstractAlgebra ring interface for inexact rings (see https://nemocas.github.io/AbstractAlgebra.jl/dev/ring_interface/#Approximation-(floating-point-and-ball-arithmetic-only))

@fingolfin
Copy link
Member

Hehe I run into the same tonight (didn't see your issue here, sadly).

They also are missing hash method.

I now made PR #1886 as a draft to share my partial work on conformance test for these (my guess is that you also have something similar, so let's collaborate instead of duplicating effort :-)

@lgoettgens
Copy link
Collaborator Author

(my guess is that you also have something similar, so let's collaborate instead of duplicating effort :-)

no, nothing on my side yet. This originated in trying to find a non-exact ring to test the ring interface changes with, in particular where I need equality and where ==.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants