From 0f66c347f7d26a6c11211931bf96c9de9ee8ea65 Mon Sep 17 00:00:00 2001 From: alok Date: Tue, 16 Jul 2019 19:39:33 +0530 Subject: [PATCH 1/4] added key --- packages/extensionmanager/src/companions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/extensionmanager/src/companions.tsx b/packages/extensionmanager/src/companions.tsx index 67f3c6eb00f5..43918e9b05b2 100644 --- a/packages/extensionmanager/src/companions.tsx +++ b/packages/extensionmanager/src/companions.tsx @@ -108,7 +108,7 @@ export function presentCompanions( let entries = []; if (serverCompanion) { entries.push( -

+

This package has indicated that it needs a corresponding server extension: {serverCompanion.base.name!} From b0619a4b05ef7b3afb18aa69daf983c7f76781cc Mon Sep 17 00:00:00 2001 From: alok Date: Fri, 19 Jul 2019 15:02:53 +0530 Subject: [PATCH 2/4] added keys inside for loop based on index --- packages/extensionmanager/src/companions.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/extensionmanager/src/companions.tsx b/packages/extensionmanager/src/companions.tsx index 43918e9b05b2..23575adb6334 100644 --- a/packages/extensionmanager/src/companions.tsx +++ b/packages/extensionmanager/src/companions.tsx @@ -117,23 +117,23 @@ export function presentCompanions( } if (kernelCompanions.length > 0) { entries.push( -

+

This package has indicated that it needs a corresponding package for the kernel.

); - for (let entry of kernelCompanions) { + for (let [index, entry] of kernelCompanions.entries()) { entries.push( -

+

The package {entry.kernelInfo.base.name!}, is required by the following kernels:

); let kernelEntries = []; - for (let kernel of entry.kernels) { + for (let [index, kernel] of entry.kernels.entries()) { kernelEntries.push( -
  • +
  • {kernel.display_name}
  • ); From b4e23f71479e43d8bba522c59f588c135019a72d Mon Sep 17 00:00:00 2001 From: alok Date: Fri, 19 Jul 2019 15:58:14 +0530 Subject: [PATCH 3/4] linted the content --- packages/extensionmanager/src/companions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/extensionmanager/src/companions.tsx b/packages/extensionmanager/src/companions.tsx index 23575adb6334..6e7aef47f2ce 100644 --- a/packages/extensionmanager/src/companions.tsx +++ b/packages/extensionmanager/src/companions.tsx @@ -117,7 +117,7 @@ export function presentCompanions( } if (kernelCompanions.length > 0) { entries.push( -

    +

    This package has indicated that it needs a corresponding package for the kernel.

    From 5fd521e4400ca8f3d261602eb2549a50a5bb1bb6 Mon Sep 17 00:00:00 2001 From: alok Date: Sat, 20 Jul 2019 11:36:38 +0530 Subject: [PATCH 4/4] implemented suggested changes --- packages/extensionmanager/src/companions.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/extensionmanager/src/companions.tsx b/packages/extensionmanager/src/companions.tsx index 6e7aef47f2ce..1cf7cde40819 100644 --- a/packages/extensionmanager/src/companions.tsx +++ b/packages/extensionmanager/src/companions.tsx @@ -117,14 +117,14 @@ export function presentCompanions( } if (kernelCompanions.length > 0) { entries.push( -

    +

    This package has indicated that it needs a corresponding package for the kernel.

    ); for (let [index, entry] of kernelCompanions.entries()) { entries.push( -

    +

    The package {entry.kernelInfo.base.name!}, is required by the following kernels: @@ -133,12 +133,12 @@ export function presentCompanions( let kernelEntries = []; for (let [index, kernel] of entry.kernels.entries()) { kernelEntries.push( -

  • +
  • {kernel.display_name}
  • ); } - entries.push(
      {kernelEntries}
    ); + entries.push(
      {kernelEntries}
    ); } } let body = (