Skip to content

Commit

Permalink
update docs and formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 committed May 21, 2019
1 parent 3db4f3c commit 3036c8a
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 14 deletions.
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,9 @@ a package by importing from it in the TypeScript file, and then running:

We also have scripts for creating and removing packages in `packages/`,
`jlpm run create:package` and `jlpm run remove:package`. When creating a package,
if it is meant to be included in the core bundle, add the `jupyterlab: { core: true }`
metadata to the `package.json`.
if it is meant to be included in the core bundle, add the `jupyterlab: { coreDependency: true }`
metadata to the `package.json`. Packages with `extension` or `mimeExtension` metadata
are considered to be a core dependency unless they are explicitly marked otherwise.

## Testing Changes to External Packages

Expand Down
6 changes: 3 additions & 3 deletions packages/application/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@
"typedoc": "^0.14.2",
"typescript": "~3.4.3"
},
"jupyterlab": {
"coreDependency": true
},
"publishConfig": {
"access": "public"
},
"jupyterlab": {
"coreDependency": true
}
}
6 changes: 3 additions & 3 deletions packages/attachments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
"typedoc": "^0.14.2",
"typescript": "~3.4.3"
},
"jupyterlab": {
"coreDependency": false
},
"publishConfig": {
"access": "public"
},
"jupyterlab": {
"coreDependency": false
}
}
6 changes: 3 additions & 3 deletions packages/cells/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@
"typedoc": "^0.14.2",
"typescript": "~3.4.3"
},
"jupyterlab": {
"coreDependency": false
},
"publishConfig": {
"access": "public"
},
"jupyterlab": {
"coreDependency": false
}
}
6 changes: 3 additions & 3 deletions packages/codeeditor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
"typedoc": "^0.14.2",
"typescript": "~3.4.3"
},
"jupyterlab": {
"coreDependency": false
},
"publishConfig": {
"access": "public"
},
"jupyterlab": {
"coreDependency": false
}
}

0 comments on commit 3036c8a

Please sign in to comment.