Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The problem with <HTML> automatically appends manifest.appcache #455

Closed
crixusshen opened this issue Jul 23, 2019 · 4 comments · May be fixed by #458
Closed

The problem with <HTML> automatically appends manifest.appcache #455

crixusshen opened this issue Jul 23, 2019 · 4 comments · May be fixed by #458

Comments

@crixusshen
Copy link

I looked at the example in offline-plugin-pwa. The file manifest.appcache is not appended to after the build. But this file automatically append to after I integration offline-plugin into my project. I found that the implementation of offline-plugin implements the update of appcache through a iframe tag. Does it contradict the automatic injection of HTML tags？
@crixusshen
Copy link
Author

I do know that pages that contain manifest= "are cached by default. So your iframe hack is the right way to do it. But I don't know that my HTML was automatically injected into the manifest tag, Is it the default behavior of the offline-plugin, or my personal problem^_^

@crixusshen
Copy link
Author

I use the version of webpack is 4.36.1. the version of offline-plugin is 5.0.7

@crixusshen
Copy link
Author

😝I found out why. the offline-plugin must be executed after the html-webpack-plugin. Now my HTML is not automatically injected the file of manifest.appcache. I guess that It could be the html-webpack-plugin cause. As long as the chunk contains the.appcache suffix it will be injected automatically.

@GGAlanSmithee GGAlanSmithee mentioned this issue Aug 14, 2019
Open
@GGAlanSmithee
Copy link
Collaborator

Hey @crixusshen nice investigation 👍 and happy you fixed your issue. I submitted a PR, #458, adding info regarding this to the docs, do you mind checking it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add info regarding html-webpack-plugin GGAlanSmithee/offline-plugin
2 participants
@crixusshen @GGAlanSmithee