-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nonpublic Accumulo IterationInterruptedException #2539
base: integration
Are you sure you want to change the base?
Replace nonpublic Accumulo IterationInterruptedException #2539
Conversation
/** | ||
* Exception thrown if an interrupt flag is detected. | ||
*/ | ||
public class IterationInterruptedException extends RuntimeException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might suggest customizing the name slightly to avoid IDE's pulling in accumulo's import of the class of the same name to avoid confusion later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Adam's comment
Is it still too close? I changed it from |
Now that I am looking one layer deeper, I realize that we were throwing that exception because we are implementing InterruptibleIterator which is an accumulo class. Is that class part of the public API? If so then we need to push for the original IteratorInterruptedException to be part of the public api. Can you push that question over to the accumulo group please? |
@ivakegg the
|
Ok, it appears that whole mechanism is basically OBE. So essentially, everywhere we were passing InterationInterruptedException should remain as is. We simply should not be implementing the InterruptibleIterator and hence should not have any flag to check on. @SethSmucker Please move that whole mechanism, and keep the places where we are passing the InterationInterruptedException back up the stack. |
If you make the changes in your other PR, then I believe this one becomes OBE and can be closed. We still need to make sure that exception is thrown up the stack. |
IterationInterruptedException is not part of Accumulo's public API.
Create IterationInterruptedException class in DataWave, replacing Accumulo's version.
part of #2443