Replace deprecated JexlArithmetic.compare() #2490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avgAGB
previously approved these changes
Aug 4, 2024
apmoriarty
previously approved these changes
Aug 5, 2024
| @@ -221,7 +222,7 @@ public boolean lessThan(final Object left, final Object right) { | |||
| for (final Object o : set) { | |||
| Object normalizedO = ValueTuple.getNormalizedValue(o); | |||
| Object normalizedRight = ValueTuple.getNormalizedValue(right); | |||
| if (compare(normalizedO, normalizedRight, LESS_THAN) < 0) { | |||
| if (compare(normalizedO, normalizedRight, JexlOperator.LT) < 0) { | |||
There was a problem hiding this comment.
I don't think the string constants on line 26 are needed anymore
warehouse/query-core/src/main/java/datawave/query/jexl/DefaultArithmetic.java
Outdated
Show resolved
Hide resolved
foster33
previously approved these changes
Aug 5, 2024
ivakegg
requested changes
Sep 4, 2024
SethSmucker
dismissed stale reviews from foster33, avgAGB, and apmoriarty
via
5af52e2
|
Why am I seeing changes to all of the docker files in the submodules in this PR. Also the formatting is failing. |
I think that they're from changes merged from integration, but I could be wrong. I've been working on the sub-modules in their own directories, so that could be it too. |
SethSmucker
force-pushed
the
task/replace-deprecated-jexlarithmetic-compare
branch
from
00b1af2
to
d779781
Compare
SethSmucker
force-pushed
the
task/replace-deprecated-jexlarithmetic-compare
branch
from
d779781
to
2525399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version used a String instead of a JexlOperator for the operator parameter. The following classes have been updated to use JexlArithmetic.compare(Object left, Object right, JexlOperator operator):
part of #2443