Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature angular16 #54

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Feature angular16 #54

merged 2 commits into from
Sep 20, 2024

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@mhenkens mhenkens force-pushed the feature/angular16 branch 5 times, most recently from de9c57a to 8e7ddc9 Compare September 10, 2024 12:19
@mhenkens mhenkens force-pushed the feature/angular16 branch 4 times, most recently from c8a9003 to 2413ba8 Compare September 20, 2024 14:13
SuperITMan
SuperITMan requested changes Sep 20, 2024
View reviewed changes
demo-app/ng16/tsconfig.json Outdated Show resolved Hide resolved
demo-app/ng16/tsconfig.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mhenkens mhenkens force-pushed the feature/angular16 branch 3 times, most recently from dc935f3 to 76ebd65 Compare September 20, 2024 14:32
SuperITMan
SuperITMan requested changes Sep 20, 2024
View reviewed changes
demo-app/ng15/tsconfig.json Outdated Show resolved Hide resolved
demo-app/ng16/tsconfig.json Outdated Show resolved Hide resolved
SuperITMan
SuperITMan requested changes Sep 20, 2024
View reviewed changes
package.json Outdated
"@angular/platform-browser": "^16.2.12",
"@angular/forms": "^16.2.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why inverting these 2 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be the order I select the line when merge conflict

@mhenkens mhenkens merged commit cc3756f into NationalBankBelgium:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan SuperITMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhenkens @SuperITMan