-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cypress tests for alphabetical index Vue component #1688
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
============================================
- Coverage 70.70% 70.66% -0.05%
Complexity 1651 1651
============================================
Files 33 33
Lines 4332 4332
============================================
- Hits 3063 3061 -2
- Misses 1269 1271 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing tests look good. A few thoughts below.
I think there could also be a test that checks for altLabels that should appear in the index. For example in the YSO Archaeology test vocabulary, there is this altLabel entry: artefacts → articles (inanimate objects)
Also, would it be a good idea to check the links to concepts as well? For example verify that the target URL is correct and/or simulate a click and verify that the concept is loaded. OTOH, there are tests like this already in vocab-home.cy.js so maybe there is no need to duplicate those. Maybe the vocab-home.cy.js tests could be moved alongside these, since they exercise the hierarchy sidebar?
All the new sidebar-related tests are now in sidebar.cy.js. This file may grow quite big since the sidebar has several components and more will be added later. Would it make sense to split it already now into e.g. sidebar-alpha.cy.js, sidebar-hierarchy.cs.js etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate failedFailed conditions |
Reasons for creating this PR
Alphabetical index has no cypress tests, this PR adds them.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 6 in #1563
Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)