From aeead3f7cd33c6510555b9e9969efa4961150f7b Mon Sep 17 00:00:00 2001 From: tvalentyn Date: Wed, 18 Sep 2024 13:49:55 -0700 Subject: [PATCH] Disable a permared suite. (#32493) * Disable a permared suite. * Disable by removing trigger-on-filechange * Remove the suite from the release validation scripts. * Try to add sickbay into name. * Don't require release suite triggers on test suites with the word 'disabled'. --- .github/build.gradle | 4 ++-- .../beam_PostCommit_XVR_GoUsingJava_Dataflow.yml | 11 +++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/build.gradle b/.github/build.gradle index 8105d8130186..c87a98109aeb 100644 --- a/.github/build.gradle +++ b/.github/build.gradle @@ -44,13 +44,13 @@ task check { paths = workflow.getAt(true).pull_request_target.paths as List } catch (Exception e) { errors.add("Fail to get the trigger path for ${fname}. " + - "Make sure it has a pull_request_target trigger.") + "Make sure it has a pull_request_target trigger.") return } // precommit and postcommit should triggered by this specific file // this is to ensure not missing test during release branch verification - if (paths != null && !paths.contains('release/trigger_all_tests.json') && !fname.toLowerCase().contains('sickbay')) { + if (paths != null && !paths.contains('release/trigger_all_tests.json') && !fname.toLowerCase().contains('sickbay') && !workflow.name.toLowerCase().contains('disabled')) { errors.add("Error validating ${fname}: " + "Please add 'release/trigger_all_tests.json' to the trigger path") return diff --git a/.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml b/.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml index 09e398288ff4..228f10b90cd0 100644 --- a/.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml +++ b/.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml @@ -13,13 +13,16 @@ # See the License for the specific language governing permissions and # limitations under the License. -name: PostCommit XVR GoUsingJava Dataflow +# TODO(https://github.com/apache/beam/issues/32492): re-enable the suite +# on cron and add release/trigger_all_tests.json to trigger path once fixed. + +name: PostCommit XVR GoUsingJava Dataflow (DISABLED) on: - schedule: - - cron: '45 5/6 * * *' + # schedule: + # - cron: '45 5/6 * * *' pull_request_target: - paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_XVR_GoUsingJava_Dataflow.json'] + paths: ['.github/trigger_files/beam_PostCommit_XVR_GoUsingJava_Dataflow.json'] workflow_dispatch: #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event