From 177ba7b108101da6199e374661e9c94106231359 Mon Sep 17 00:00:00 2001 From: clarissarichard <107963214+clarissarichard@users.noreply.github.com> Date: Mon, 8 Apr 2024 12:18:54 -0400 Subject: [PATCH 1/4] Revert "Update locations header link locator" This reverts commit 0f2cfc69bdfd2cdb6c1a2e3abfcc11c7b7ea09c1. --- playwright/support/mappings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playwright/support/mappings.ts b/playwright/support/mappings.ts index 127648d5..80146b5f 100644 --- a/playwright/support/mappings.ts +++ b/playwright/support/mappings.ts @@ -159,7 +159,7 @@ export const elements = { "catalog header link": "span:text('Go To The Catalog')", "research catalog header link": "span:text('Go To The Research Catalog')", "close my account header link": "[aria-label='Close']", - "locations header link": "[href='https://www.nypl.org/locations']:text('Locations')", + "locations header link": "[href='https://www.nypl.org/locations']", "library card header link": "[href='https://www.nypl.org/library-card/new']", "email updates header link": "[href='https://pub.email.nypl.org/subscriptioncenter']", From 29fa09790f98c62c8f77dfb91e354458a446c38f Mon Sep 17 00:00:00 2001 From: clarissarichard <107963214+clarissarichard@users.noreply.github.com> Date: Mon, 8 Apr 2024 12:29:17 -0400 Subject: [PATCH 2/4] Updated locations header link locator --- playwright/support/mappings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playwright/support/mappings.ts b/playwright/support/mappings.ts index 80146b5f..127648d5 100644 --- a/playwright/support/mappings.ts +++ b/playwright/support/mappings.ts @@ -159,7 +159,7 @@ export const elements = { "catalog header link": "span:text('Go To The Catalog')", "research catalog header link": "span:text('Go To The Research Catalog')", "close my account header link": "[aria-label='Close']", - "locations header link": "[href='https://www.nypl.org/locations']", + "locations header link": "[href='https://www.nypl.org/locations']:text('Locations')", "library card header link": "[href='https://www.nypl.org/library-card/new']", "email updates header link": "[href='https://pub.email.nypl.org/subscriptioncenter']", From 0c69bbaa6179405b408d60e2d10d53be122c8762 Mon Sep 17 00:00:00 2001 From: clarissarichard <107963214+clarissarichard@users.noreply.github.com> Date: Mon, 8 Apr 2024 12:54:00 -0400 Subject: [PATCH 3/4] Updated changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 43af9eeb..10a345c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - SFR-1917: Fixed failing Playwright tests - Add APP_ENV build arg in yml file and Dockerfile - Update Github Action for release from create-release to action-gh-release +- SFR-1945: Fixed more failing Playwright tests ## [0.18.0] From 1c1abaea7dde8479a669bad9f4adb1feaa413b92 Mon Sep 17 00:00:00 2001 From: clarissarichard <107963214+clarissarichard@users.noreply.github.com> Date: Mon, 8 Apr 2024 13:02:27 -0400 Subject: [PATCH 4/4] Corrected lint error --- playwright/support/mappings.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/playwright/support/mappings.ts b/playwright/support/mappings.ts index 127648d5..3b6b3664 100644 --- a/playwright/support/mappings.ts +++ b/playwright/support/mappings.ts @@ -159,7 +159,8 @@ export const elements = { "catalog header link": "span:text('Go To The Catalog')", "research catalog header link": "span:text('Go To The Research Catalog')", "close my account header link": "[aria-label='Close']", - "locations header link": "[href='https://www.nypl.org/locations']:text('Locations')", + "locations header link": + "[href='https://www.nypl.org/locations']:text('Locations')", "library card header link": "[href='https://www.nypl.org/library-card/new']", "email updates header link": "[href='https://pub.email.nypl.org/subscriptioncenter']",