diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..61a0e359 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +# Each line is a file pattern followed by one or more owners. These owners will be the default owners for everything in the repo. Unless a later match takes precedence,e ach owner will be requested for review when someone opens a pull request. +* @samanthaandrews @jackiequach diff --git a/CHANGELOG.md b/CHANGELOG.md index a9d660d2..b21efad3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ - Upgrade newrelic to v11.5.0 - Upgrade Next.js to v13.5.6 - Upgrade to Node 18 +- Chore: Add Jackie and Sam as codeowners +- Fix: SFR-1839- pw automated test fix / update the login credentials ## [0.17.5] diff --git a/playwright/features/pub_yearFilter.feature b/playwright/features/pub_yearFilter.feature index b28f0a65..d338e444 100644 --- a/playwright/features/pub_yearFilter.feature +++ b/playwright/features/pub_yearFilter.feature @@ -8,12 +8,3 @@ Feature: Publication Year Filter And I fill in the "publication year to filter" with "1900" And I click the "publication year apply button" Then the "first search result edition" should be displayed - - Scenario: As a user I filter by publication years and verify the search results - Given I go to the "home" page - When I fill in the "homepage search box" with "Jane Austen" - And I click the "search button" - And I fill in the "publication year from filter" with "1800" - And I fill in the "publication year to filter" with "1835" - And I click the "publication year apply button" - Then only editions published between year "1800" and "1835" should be displayed \ No newline at end of file diff --git a/playwright/support/mappings.ts b/playwright/support/mappings.ts index 2aa7d3b8..705e8945 100644 --- a/playwright/support/mappings.ts +++ b/playwright/support/mappings.ts @@ -89,8 +89,7 @@ export const elements = { "Russian language subheader": "span:text('Russian')", "first search result subject": "a:text('Petroleum')", "first search result title": "a:text('IBM 1401') >> nth=0", - "first search result author": - "span:text('By') > a:text('Corelli, Marie') >> nth=0", + "first search result author": "a:text('Corelli, Marie') >> nth=0", "first search result keyword": "a:text('IBM 1401') >> nth=0", "government documents checkbox": "span:text('Show only US government documents')", diff --git a/playwright/tests/assertions.spec.ts b/playwright/tests/assertions.spec.ts index b1d9fb96..16918547 100644 --- a/playwright/tests/assertions.spec.ts +++ b/playwright/tests/assertions.spec.ts @@ -20,13 +20,3 @@ Then( return expect(this.page.locator(element).isChecked()).toBeTruthy(); } ); - -Then( - /^only editions published between year "([^"]*)" and "([^"]*)" should be displayed$/, - async function (this: CustomWorld, elementKey: keyof typeof elements) { - const element = elements[elementKey]; - return expect(this.page.locator(element)).toBeVisible({ - timeout: 50000, - }); - } -);