From 3d5660cb0027d44aeb67c54b66fd2656e3694389 Mon Sep 17 00:00:00 2001 From: Jackie Quach Date: Thu, 11 Jul 2024 10:26:57 -0400 Subject: [PATCH 1/3] update jira link on pr template --- .github/PULL_REQUEST_TEMPLATE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 5cdbad83..f0f7ddac 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -1,4 +1,4 @@ -[Jira Ticket](http://jira.nypl.org/browse/SFR-XXX) +[Jira Ticket](https://newyorkpubliclibrary.atlassian.net/browse/SFR-XXX) ### This PR does the following: - From d0804327997803057be24a5108f2cdf12e6f7b7d Mon Sep 17 00:00:00 2001 From: Jackie Quach Date: Thu, 11 Jul 2024 10:28:32 -0400 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad3d50c8..173e0532 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Fix cut off text on search bar dropdown - Fix broken link on the About page - SFR-2008: Automate License Page Headers and Sub-Headers +- Update PR template with new Jira link ## [0.18.1] From 1da12b28dfc0b979bd07c0862f9c6af9f3849106 Mon Sep 17 00:00:00 2001 From: Shejanul Ayan Islam <100955969+ayan1229@users.noreply.github.com> Date: Fri, 12 Jul 2024 13:05:40 -0400 Subject: [PATCH 3/3] SFR-2033/verify-nypl-header-links (#508) * SFR-2033/first-commit-for-review * SFR-2033/first-commit --- CHANGELOG.md | 1 + playwright/features/headerLinks.feature | 57 +++++++++++++++---------- playwright/support/mappings.ts | 8 ++++ 3 files changed, 44 insertions(+), 22 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad3d50c8..5566a39d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Fix cut off text on search bar dropdown - Fix broken link on the About page - SFR-2008: Automate License Page Headers and Sub-Headers +- SFR-2033: Verify the external NYPL header links of DRB App ## [0.18.1] diff --git a/playwright/features/headerLinks.feature b/playwright/features/headerLinks.feature index a9101ccc..38e216e9 100644 --- a/playwright/features/headerLinks.feature +++ b/playwright/features/headerLinks.feature @@ -18,17 +18,17 @@ Feature: Header Links And the "get help header link" should be displayed And the "search header link" should be displayed - Examples: - | DRB | - | "home" | - | "advanced search" | - | "search results" | - | "item details" | - | "edition details" | - | "collection" | - | "read online" | - | "license" | - | "about" | + Examples: + | DRB | + | "home" | + | "advanced search" | + | "search results" | + | "item details" | + | "edition details" | + | "collection" | + | "read online" | + | "license" | + | "about" | Scenario: As a user I navigate to the Digital Research Books home page and verify the account and search header sub-links and elements are displayed Given I go to the "home" page @@ -36,14 +36,27 @@ Feature: Header Links Then the should be displayed Examples: - | first header link | second header link | - | "my account header link" | "catalog header link" | - | "my account header link" | "research catalog header link" | - | "my account header link" | "close my account header link" | - | "search header link" | "search header label" | - | "search header link" | "search header text field" | - | "search header link" | "search books music movies radio button" | - | "search header link" | "search research catalog radio button" | - | "search header link" | "search library website radio button" | - | "search header link" | "search header button" | - | "search header link" | "close search header link" | + | first header link | second header link | + | "my account header link" | "catalog header link" | + | "my account header link" | "research catalog header link" | + | "my account header link" | "close my account header link" | + | "search header link" | "search header label" | + | "search header link" | "search header text field" | + | "search header link" | "search books music movies radio button" | + | "search header link" | "search research catalog radio button" | + | "search header link" | "search library website radio button" | + | "search header link" | "search header button" | + | "search header link" | "close search header link" | + + Scenario: As a user when I click on Locations I should be directed to NYPL location page + Given I go to the "home" page + Then I click the + And the should be displayed + + Examples: + | first header link | landing page header | + | "locations header link" | "locations page header" | + | "library card header link" | "get a library card page header" | + | "email updates header link" | "get email updates page header" | + | "donate header link" | "donation page button" | + | "shop header link" | "shop page footer" | diff --git a/playwright/support/mappings.ts b/playwright/support/mappings.ts index 210ca343..305aee54 100644 --- a/playwright/support/mappings.ts +++ b/playwright/support/mappings.ts @@ -215,6 +215,14 @@ export const elements = { "//p[contains(text(),'Works may be in the public domain in the Unites St')]", "public domain us only subheader": "//p[contains(text(),'Works may be in the public domain in the Unites States')]", + + /** external page locators */ + "locations page header": + "//div[contains(text(),'Welcome to The New York Public Library. Discover o')]", + "get a library card page header": "//h1[@id='hero-banner']", + "get email updates page header": "//h1[@id='page-title']", + "donation page button": "//button[text()='Donate']", + "shop page footer": "//h2[text()='All Proceeds Support the Library']", }; export const inputs = {